New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS1/ROS2 Hybrid Packages #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWhitleyWork
requested review from
Daniel-Stanek,
rgunjala-as,
cbradyas,
shan-as,
icolwell-as,
as-snehagn and
jilinzhouas
November 19, 2019 17:53
Daniel-Stanek
approved these changes
Nov 19, 2019
Looks like the old at_ui has a couple of places. It's no longer used, but it's still in ros_hmi, and that's used. The ros_points_of_interest repo is so old it's probably not worth it.
Daniel Stanek
AutonomouStuff, LLC
T: 314-270-2123 | F: 309-481-5425
dstanek@autonomoustuff.com<mailto:jwhitley@autonomoustuff.com> | www.AutonomouStuff.com<http://www.AutonomouStuff.com/>
Bringing Together the World's Best Technologies™
The preceding e-mail message (including any attachments) contains information that may be confidential, may be protected by the attorney-client or other applicable privileges, or may constitute non-public information. It is intended to be conveyed only to the designated recipient(s) named above. If you are not an intended recipient of this message, please notify the sender by replying to this message and then delete all copies of it from your computer system. Any use, dissemination, distribution, or reproduction of this message by unintended recipients is not authorized and may be unlawful.
…________________________________
From: Joshua Whitley <notifications@github.com>
Sent: Tuesday, November 19, 2019 11:53 AM
To: astuff/automotive_autonomy_msgs <automotive_autonomy_msgs@noreply.github.com>
Cc: Daniel Stanek <dstanek@autonomoustuff.com>; Mention <mention@noreply.github.com>
Subject: [astuff/automotive_autonomy_msgs] ROS1/ROS2 Hybrid Packages (#15)
This email comes from outside the organization.
This PR migrates all message packages in this repo to ROS1/ROS2 hybrid packages. The only substantive change is PointOfInterestRequest.requestId to PointOfInterestRequest.request_id and the same for PointOfInterestResponse.requestId to PointOfInterestResponse.request_id. Migration rules were created to update these messages.
@Daniel-Stanek<https://github.com/Daniel-Stanek> - Please let me know which (if any) packages need to be updated to accommodate this change.
________________________________
You can view, comment on, or merge this pull request online at:
#15
Commit Summary
* Hybridizing all packages.
* Making all messages ROS2-compliant.
* Fixing XML linting errors.
* CI: Adding Dashing build.
* Adding migration rules.
File Changes
* M .circleci/config.yml<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-0> (29)
* M automotive_autonomy_msgs/CMakeLists.txt<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-1> (15)
* M automotive_autonomy_msgs/package.xml<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-2> (13)
* M automotive_navigation_msgs/CMakeLists.txt<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-3> (121)
* A automotive_navigation_msgs/migration/PointOfInterestRequest.bmr<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-4> (103)
* A automotive_navigation_msgs/migration/PointOfInterestResponse.bmr<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-5> (111)
* M automotive_navigation_msgs/msg/DesiredDestination.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-6> (2)
* M automotive_navigation_msgs/msg/Direction.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-7> (2)
* M automotive_navigation_msgs/msg/DistanceToDestination.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-8> (2)
* M automotive_navigation_msgs/msg/PointOfInterestRequest.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-9> (2)
* M automotive_navigation_msgs/msg/PointOfInterestResponse.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-10> (2)
* M automotive_navigation_msgs/package.xml<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-11> (34)
* M automotive_platform_msgs/CMakeLists.txt<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-12> (136)
* M automotive_platform_msgs/msg/AdaptiveCruiseControlCommand.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-13> (2)
* M automotive_platform_msgs/msg/AdaptiveCruiseControlSettings.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-14> (2)
* M automotive_platform_msgs/msg/CabinReport.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-15> (2)
* M automotive_platform_msgs/msg/UserInputADAS.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-16> (2)
* M automotive_platform_msgs/msg/UserInputMedia.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-17> (2)
* M automotive_platform_msgs/msg/UserInputMenus.msg<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-18> (2)
* M automotive_platform_msgs/package.xml<https://github.com/astuff/automotive_autonomy_msgs/pull/15/files#diff-19> (29)
Patch Links:
* https://github.com/astuff/automotive_autonomy_msgs/pull/15.patch
* https://github.com/astuff/automotive_autonomy_msgs/pull/15.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#15?email_source=notifications&email_token=AHOEIYDRG7ONNBLKBO72LD3QUQR3LA5CNFSM4JPHCWI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2NNQYQ>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHOEIYCCD754KHF3UTMBUQ3QUQR3LANCNFSM4JPHCWIQ>.
|
as-snehagn
approved these changes
Nov 19, 2019
icolwell-as
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all message packages in this repo to ROS1/ROS2 hybrid packages. The only substantive change is
PointOfInterestRequest.requestId
toPointOfInterestRequest.request_id
and the same forPointOfInterestResponse.requestId
toPointOfInterestResponse.request_id
. Migration rules were created to update these messages.@Daniel-Stanek - Please let me know which (if any) packages need to be updated to accommodate this change.