Fix UDP read function #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… receiving packet
icolwell-as
requested review from
shan-as,
dvangeyn-as,
jilinzhouas and
cbrown-as
dvangeyn-as
approved these changes
Mar 23, 2021
shan-as
approved these changes
Mar 26, 2021
jilinzhou
reviewed
Mar 29, 2021
| @@ -50,6 +51,7 @@ class UDPInterface | |||
| ReturnStatuses write(const std::vector<uint8_t>& msg); | |||
|
|
|||
| private: | |||
| uint receive_buffer_size_ = 1024; | |||
jilinzhou
reviewed
Mar 29, 2021
| @@ -19,6 +19,12 @@ UDPInterface::UDPInterface() : | |||
| { | |||
| } | |||
|
|
|||
| ReturnStatuses UDPInterface::open(std::string ip_address, const int &port, uint receive_buffer_size) | |||
jilinzhou
reviewed
Mar 29, 2021
| receive_buffer_size_ = receive_buffer_size; | ||
| return UDPInterface::open(ip_address, port); | ||
| } | ||
|
|
||
| ReturnStatuses UDPInterface::open(std::string ip_address, const int &port) |
There was a problem hiding this comment.
should be (const std::string& ip_address, int port)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #32, see issue for more details.