allow for optimize without commits, surface commit API to python client for deferred committing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asura-io
force-pushed
the
gautham/release-gil
branch
21 times, most recently
from
7677d64
to
cc51d41
Compare
asura-io
changed the title
houqp
reviewed
Mar 7, 2024
houqp
reviewed
Mar 7, 2024
houqp
reviewed
Mar 7, 2024
houqp
reviewed
Mar 7, 2024
houqp
reviewed
Mar 7, 2024
python/src/lib.rs
Outdated
|
|
||
| let commit = match &self._commit { | ||
| Some(c) => c, | ||
| None => panic!("No commit found from previous optimize, cannot commit."), |
houqp
reviewed
Mar 7, 2024
houqp
reviewed
Mar 7, 2024
houqp
reviewed
Mar 7, 2024
asura-io
force-pushed
the
gautham/release-gil
branch
8 times, most recently
from
3dc4670
to
3ecc344
Compare
fix: clean up unnecessay mut and dead code warnings
asura-io
force-pushed
the
gautham/release-gil
branch
7 times, most recently
from
e549858
to
f5f70ed
Compare
houqp
reviewed
Mar 8, 2024
| self, | ||
| commit_info: CommitContext | ||
| ) -> DeltaResult<DeltaTable> { | ||
| let _ = commit( |
There was a problem hiding this comment.
Updated to use ? and propagate the error
asura-io
force-pushed
the
gautham/release-gil
branch
from
f5f70ed
to
444d4d6
Compare
asura-io
commented
Mar 8, 2024
|
|
||
| rt()?.block_on( | ||
| cmd.commit_writes( | ||
| self._commit.take().unwrap() |
There was a problem hiding this comment.
@houqp is this the best way to handle this case? .take().unwrap()?
| Some(CommitContext{ | ||
| actions: total_actions, | ||
| app_metadata, | ||
| snapshot: Some(snapshot.clone()), // using original table snapshot as all commits are added at once |
There was a problem hiding this comment.
Not 100% sure if this is correct -- maybe we need to use table.snapshot() if there were other writes?
| self, | ||
| commit_info: CommitContext | ||
| ) -> DeltaResult<DeltaTable> { | ||
| let _ = commit( |
There was a problem hiding this comment.
Updated to use ? and propagate the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The description of the main changes of your pull request
Related Issue(s)
Documentation