fix: update AsvMavlinkVersion and validate azimuth values #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated AsvMavlinkVersion in Asv.Drones.Gui.Custom.props from 3.6.0-alpha08 to 3.6.0-alpha11 for supporting the latest features and bug fixes. In VorAzimuthTaskViewModel, added validation before setting StartAzimuthString and StopAzimuthString. Ensured StartAzimuth and StopAzimuth values are positive and less than 360. This is because, in some cases, supplying out of range or negative direction values can cause errors in the system. Removed unnecessary methods from MissionItemHelper for cleaner codebase as these methods were outdated and replaced in the Mavlink ecosystem. Asana: https://app.asana.com/0/1203851531040615/1206117606525836/f
asv-soft-u01
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated AsvMavlinkVersion in Asv.Drones.Gui.Custom.props from 3.6.0-alpha08 to 3.6.0-alpha11 for supporting the latest features and bug fixes. In VorAzimuthTaskViewModel, added validation before setting StartAzimuthString and StopAzimuthString. Ensured StartAzimuth and StopAzimuth values are positive and less than 360. This is because, in some cases, supplying out of range or negative direction values can cause errors in the system. Removed unnecessary methods from MissionItemHelper for cleaner codebase as these methods were outdated and replaced in the Mavlink ecosystem.
Asana: https://app.asana.com/0/1203851531040615/1206117606525836/f