Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use aliases in the package #27

Closed
ghost opened this issue Sep 7, 2016 · 3 comments
Closed

Do not use aliases in the package #27

ghost opened this issue Sep 7, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Sep 7, 2016

Do not use aliases in the package.
This forces the user to include aliases in the app configuration, even if he does not use them in own application.

See: src/Http/routes.php

@ghost
Copy link
Author

ghost commented Sep 7, 2016

Moreover, you can get unpredictable behavior if the alias will refer to the other facade (not the default).

@asvae
Copy link
Owner

asvae commented Sep 7, 2016

Thanks. That definitely should be fixed. I imagine someone could even not use aliases.

@asvae
Copy link
Owner

asvae commented Sep 8, 2016

Fixed 0132f11

@asvae asvae closed this as completed Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant