fixed Node-detection #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was depending on the window-property which is at least in the Electron-environment available although the javascript is running in a Node-process. The new detection-statement relies on the [`process.release`](https://nodejs.org/api/process.html#process_process_release)-object which allows the safe identification of node.js and io.js.
|
Good point, thanks! I did not investigate much on proper detection before, and just picked the first solution that worked. (I'm working on the project by myself, so there's not that much rules 馃槃) |
|
No worries - i'm happy you created and offer jailed! 馃槂 (And if i get a clue to improve something you'll receive another PR.. 馃槈) |
|
sure, you are welcome! 馃憤 (but I don't accept everything just like that 馃槈) |
mickeyh
pushed a commit
to mickeyh/jailed
that referenced
this pull request
Jun 13, 2016
`__jailed__path__` is defined depending on whether the environment is Node or a browser. The earlier node detection fix was not applied to the code that controlled how `__jailed__path__` was populated. See asvd#25 for original node detection fix.
mickeyh
pushed a commit
to mickeyh/jailed
that referenced
this pull request
Jun 13, 2016
`__jailed__path__` is defined depending on whether the environment is Node or a browser. The earlier node detection fix was not applied to the code that controlled how `__jailed__path__` was populated. See asvd#25 for original node detection fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was depending on the window-property which is at least in the Electron-environment available although the javascript is running in a Node-process.
The new detection-statement relies on the
process.release-object which allows the safe identification of node.js and io.js.P.s.: I didn't open an issue since it seems to be an atomic change. I hope filing immediately a PR is not considered as rude behaviour.
馃嵒