Fix marks jumping

[Shatur]

Closes #228.

[Shatur]

BTW, I noticed that you use something like

nnoremap <silent> <C-o> :<C-u>call <SID>jump(0)<CR>

This can be done in more convenient syntax:

nnoremap <C-o> <Cmd>call <SID>jump(0)<CR>

Let me know if you like the idea, I will send a PR.

[asvetliakov]

nnoremap <C-o> <Cmd>call <SID>jump(0)<CR>

I like, but <Cmd> has slightly different semantics. Be careful when changing it

[asvetliakov]

Why <C-o> here? What about jumping with `A and 'A ?

[Shatur]

Omg, sorry, just a stupid typo after merge. Fixed.

[asvetliakov]

what about 'A ?

[Shatur]

Hm... The shortcut is working, but let g:isJumping = 1 and let g:isJumping = 0 does not have effect. It works just like before.

[Shatur]

Do <C-o> and <C-i> work for you for jumping between files?
All this shortcuts do not jump between files for me.

[asvetliakov]

Do <C-o> and <C-i> work for you for jumping between files?

Yes

I just tried PR, it doesn't work. But changing these to:

function! s:jumpToMark() abort
    let g:isJumping = 1
    normal! `A
    let g:isJumping = 0
endfunction

nnoremap `A <Cmd>call <SID>jumpToMark()<CR>

then mA in first file, then `A in other file correctly jumps. So i guess we shouldn't do operator remap here and use nnoremap in a loop

[Shatur]

Yes

This is strange. What I have tried:

0. Remove all my Neovim settings an plugins.
1. Open this branch in VSCode.
2. Launch the extension (another VSCode instance opened)
3. Open any file. Then open another file in split.
4. Jump to the end, then jump to another side of split, then jump to the beggining.
5. Press <C-o> - jumping occurs only inside single file.

I just tried PR, it doesn't work.

Of course. But for me even any jumping do not works between two files.
Do I understand correctly that ` from this PR works, it just does not move between files (e.g. it does not fixes the problem)?
I guess you have <C-i> and <C-o> reassigned to workbench.action.navigateBack and workbench.action.navigateForward in VSCode settings. Could you check it?

[asvetliakov]

Open any file. Then open another file in split.
Jump to the end, then jump to another side of split, then jump to the beggining.

Jumplist is each own separate por editor column and not being inherited by split commands (see readme) 😄

open another file in the same column, switch between them and use <C-o> / <C-i>, it should work

[Shatur]

Jumplist is each own separate por editor column and not being inherited by split commands (see readme) smile

Still not works for me. What I tried

1. Opened any file.
2. Open another file (now I have two tabs)
3. <C-o> - nothing happened.
4. G - jumped to the end
5. <C-o> - jumped to the previous position
6. <C-o> - nothing happened.
7. Swith to the previous tab.
8. <C-o> - nothing happened.

I also updated this branch to the latest master just to be sure. Also this was done without any settings.

[Shatur]

Oh, got it. The problem was in workbench.editor.enablePreview set to true. Because of it <C-o> and <C-i> not works even if I keeping tabs in editor.

If workbench.editor.enablePreview is set to true it works. But it also have issues. Try the following:

0. Close all tabs.
1. Open first file.
2. Open second file.
3. <C-o>. It jumps to first file.
4. Open third file
5. <C-o>. It jumps to first file.
6. <C-o>. It jumps to first file.
   This hotkey shouldn't have done that.

Another issue I noticed:

1. Open a lot of files.
2. Close them quickly except one.
3. Quickly press <C-o> a lot of time.
   You will have several Untitled buffers with content insted of opened files. It happens sometimes, but often. Try 1-3 steps two-three times and you should reproduce it.

Is it possible to improve jumping system? I think this should be done before fixing marks.

[asvetliakov]

You will have several Untitled buffers with content insted of opened files. It happens sometimes, but often. Try 1-3 steps two-three times and you should reproduce it.

I noticed this problem too, for some reason neovim sends /file/path instead file:/// uri when jumping and vscode ignores it. Will try to solve it by either fixing neovim or by accepting paths too

6. . It jumps to first file.
   This hotkey shouldn't have done that.

There are limitations with jumping. Opening a buffer doesn't create a jumppoint. Not easy to solve

[Shatur]

There are limitations with jumping. Opening a buffer doesn't create a jumppoint. Not easy to solve

Maybe use VSCode jumping for <C-o> / <C-i>? Yes, it works a bit differently, but do not have issues.

[asvetliakov]

Maybe use VSCode jumping for / ? Yes, it works a bit differently, but do not have issues.

Unfortunately vscode jumping is completely broken because setting vscode cursor is creating vscode jumppoint for each cursor move

[Shatur]

Unfortunately vscode jumping is completely broken because setting vscode cursor is creating vscode jumppoint for each cursor move

Yes :(
But I use this in my vimrc for now to avoid current jumping issues.

[asvetliakov]

Probably can be workarounded by using vscode's cursorMove command. But need to count character shifting then between old & new cursor pos. Oh, and marks won't work too. Nope (only m' wont work so actually can be valid idea)

[asvetliakov]

cursorMove

Nope. cursorMove vscode command stops when reaching a new line and ignoring given value count. Possible workaround it here too but too clunky. Need to fix vim jumplist

[Shatur]

Closed after #461.