OpenCV version of locateAll #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyscreeze.locateAll will use OpenCV tools if the needed libs can be imported, else default to pure python benefits: faster performance if cv2 and numpy are available (but don't require them as dependencies) costs: more code to maintain limitations: early ~beta status; see doc string in _locateAll_opencv
alpha channels in RGBA are not going to be easy or possible to support at this time.
|
The change looks good. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyscreeze.locateAll will use OpenCV tools if the needed libs can be imported, else default to pure python
benefits: faster performance if cv2 and numpy are available (but don't require them as dependencies)
costs: more code to maintain, slightly more RAM needed
limitations: early ~beta status; see doc string in _locateAll_opencv