Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce NNI with distributed Adaptive API #331

Merged
merged 19 commits into from
Feb 2, 2021

Conversation

ZeyaWang
Copy link
Collaborator

This PR adds an example to Texar-Pytorch about how to run NNI experiments with distributed Adaptive API with the help of AdaptDL.

examples/bert/bert_classifier_adaptive_nni.py is th the nni version of examples/bert/bert_classifier_adaptive.py. config_bert_classifier.yml is the configuration file to run the experiment.

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #331 (26d93c4) into master (a061b45) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   80.14%   80.17%   +0.02%     
==========================================
  Files         135      136       +1     
  Lines       11220    11242      +22     
==========================================
+ Hits         8992     9013      +21     
- Misses       2228     2229       +1     
Impacted Files Coverage Δ
texar/torch/losses/info_loss.py 95.45% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a061b45...26d93c4. Read the comment docs.

Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can wait and merge this only when all dependencies are open-sourced.

The docker build command here requires a petuum registry, any way for a non-petuum user to reproduce this?

docker/Dockerfile Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
examples/bert/README.md Outdated Show resolved Hide resolved
examples/bert/README.md Outdated Show resolved Hide resolved
@ZeyaWang
Copy link
Collaborator Author

We can wait and merge this only when all dependencies are open-sourced.

The docker build command here requires a petuum registry, any way for a non-petuum user to reproduce this?

In the updated ReadMe file, we further provide guidance about how to build and push a docker image to their own private registry and a link about how to create Secrete and use Secrete to pull image from the private registry in K8S. With this guide, the user is able to reproduce all the steps about the docker images.

@hunterhector hunterhector merged commit b95e810 into asyml:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants