Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete error message #345

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Conversation

zhanyuanucb
Copy link
Contributor

The previous error message is confusing.
Even though a user passes in kwargs , since allow_new_hparam is set toFalse, the error message will still say that Only hyperparameters named 'kwargs' hyperparameters can contain new entries undefined in default hyperparameters.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #345 (09a02be) into master (dae9a8f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files         135      135           
  Lines       11359    11359           
=======================================
  Hits         9137     9137           
  Misses       2222     2222           
Impacted Files Coverage Δ
texar/torch/hyperparams.py 86.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae9a8f...09a02be. Read the comment docs.

@hunterhector hunterhector merged commit d0885c4 into asyml:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants