Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SNS publish batch #1143

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Added SNS publish batch #1143

merged 2 commits into from
Dec 16, 2021

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Dec 16, 2021 •
edited
Loading

This PR adds support for the new SNS PublishBatch action.

@GrahamCampbell GrahamCampbell changed the title Added SNS batch actions Added SNS batch publish Dec 16, 2021
@GrahamCampbell GrahamCampbell changed the title Added SNS batch publish Added SNS publish batch Dec 16, 2021
jderusse
jderusse approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please rebase the PR to get a green CI?

src/Service/Sns/composer.json Show resolved Hide resolved
@GrahamCampbell GrahamCampbell marked this pull request as ready for review December 16, 2021 12:36
@GrahamCampbell
Copy link
Contributor Author

Re-based and a typo fixed. 🚀

@jderusse jderusse enabled auto-merge (squash) December 16, 2021 16:09
@jderusse jderusse merged commit 02dff5b into async-aws:master Dec 16, 2021
@GrahamCampbell GrahamCampbell deleted the sns-batch branch December 16, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GrahamCampbell @jderusse