Add an accept header in JSON request to help 3rd party services like …

…localstack (#1721)
async-aws · Jun 5, 2024 · c35bc94 · c35bc94
1 parent 4073986
commit c35bc94
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Changed
+
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
+
 ## 1.1.0
 
 ### Added

diff --git a/src/Input/PutTraceSegmentsRequest.php b/src/Input/PutTraceSegmentsRequest.php
@@ -55,7 +55,10 @@ public function getTraceSegmentDocuments(): array
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/tests/Unit/Input/PutTraceSegmentsRequestTest.php b/tests/Unit/Input/PutTraceSegmentsRequestTest.php
@@ -24,7 +24,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/xray/latest/api/API_PutTraceSegments.html
         $expected = '
             POST /TraceSegments HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
             "TraceSegmentDocuments": [