Automatically generate an input name with a suffix

[ClementNerma]

Hi!

Would it be possible, when using both SimpleObject and InputObject on the same struct, or both Union and OneofObject, to make the input type automatically suffixed?

For instance, the following code:

#[derive(SimpleObject, InputObject)]
#[graphql(input_name_suffix = "Input")]
struct Test { /* ... */ }

Would now compile just like we wrote:

#[derive(SimpleObject, InputObject)]
#[graphql(input_name = "TestInput")]
struct Test { /* ... */ }

This would be immensely helpful in macros, especially as #[graphql(input_name = "...")] doesn't accept variables.

What do you think of this?

[sunli829]

This is definitely a good idea, but now that we already have an input_name attribute, adding an input_name_suffix attribute is a bit redundant. 🙂

[ClementNerma]

This is definitely a good idea, but now that we already have an input_name attribute, adding an input_name_suffix attribute is a bit redundant. 🙂

The problem is that input_name can't be used in macros, due to the unability to concatenate strings in it.

If I do:

// ...
#[derive(SimpleObject, InputObject)]
#[graphql(input_name = concat!($name, "Input")]
pub struct $name {
  // ...
}

This will not compile as input_name is expecting a literal.

[ClementNerma]

I opened a PR to add this change, it ended up being really trivial: #1119