Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error extensions cause stack overflow #719

Closed
neslinesli93 opened this issue Nov 22, 2021 · 1 comment
Closed

Error extensions cause stack overflow #719

neslinesli93 opened this issue Nov 22, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@neslinesli93
Copy link

Expected Behavior

When using error extensions, I should be able to implement the ErrorExtensions trait for my errors and then call error.extend() inside resolvers. When querying a field that returns an error, I should be able to see the error along with the code and other custom fields I may add

Actual Behavior

The program crashes when calling the graphql endpoint. Here is the stacktrace

thread 'actix-rt|system:0|arbiter:0' has overflowed its stack
fatal runtime error: stack overflow

Steps to Reproduce the Problem

  1. Run the error-extensions example contained in the examples folder
  2. Call the extend query on the schema
  3. The server crashes

Basically the code goes in a loop on this line, and then ultimately crashes

Specifications

  • Version: Reproduced with the branches actix-web-v4-beta and master
  • Platform:
  • Subsystem:
@neslinesli93 neslinesli93 added the bug Something isn't working label Nov 22, 2021
@sunli829
Copy link
Collaborator

Fixed in v3.0.7 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants