Result in subscription sends a Complete message on error

[Sytten]

Expected Behavior

When creating a stream like impl Stream<Item = Result<i32>> and returning an Err, it should not send a Complete message as the stream might not be ended, just that it had an error.

Actual Behavior

The server sends a complete message, closing the subscription.

Steps to Reproduce the Problem

1. Create a subscription that returns a Result
2. Return an Err
3. The complete message is sent

Specifications

• Version: Commit 3c6c933 (actix-v4 branch)

[sunli829]

I think you are right, I shouldn't assume that the stream ends when it returns to Err. 😁

[sunli829]

Released in v3.0.13

[Sytten]

Nice I will be able to test once we update the actix v4 branch I guess.