Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@deprecated not turning up in generated schema #874

Closed
djc opened this issue Mar 21, 2022 · 3 comments
Closed

@deprecated not turning up in generated schema #874

djc opened this issue Mar 21, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@djc
Copy link
Contributor

djc commented Mar 21, 2022

Expected Behavior

If I mark some resolvers in an #[Object] impl with #[graphql(deprecation = "Blah")], I would expect these to be marked with @deprecated in the generated schema. I could not find anything about this in the book but managed to find some mentions by searching the repository (and then looking for the reference documentation for the #[Object] attribute macro).

Actual Behavior

I can add the attribute with or without reason and async-graphql will generate a schema for me, but it doesn't add @deprecated directives.

Specifications

  • Version: 3.0.35
  • Platform: macOS
@djc djc added the bug Something isn't working label Mar 21, 2022
@sunli829
Copy link
Collaborator

I forgot to add this, will do it now. 😂

sunli829 added a commit that referenced this issue Mar 22, 2022
Expose `Connection::edges` #871
@sunli829
Copy link
Collaborator

Fixed in v3.0.36 😁

@djc
Copy link
Contributor Author

djc commented Mar 22, 2022

Thanks!

@djc djc closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants