Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define override directive on fields #1029

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

raptros
Copy link
Contributor

@raptros raptros commented Aug 19, 2022

relevant to #982
todo

  • test locally
  • implement the directive correctly (it needs to take a string param)
  • update docs

@raptros
Copy link
Contributor Author

raptros commented Aug 19, 2022

not even sure what version of rust i should try to use....
i tried 1.59 and started getting

± cargo build --all-features
    Updating crates.io index
error: failed to select a version for the requirement `phf = "^0.11"`
candidate versions found which didn't match: 0.10.1, 0.10.0, 0.9.0, ...
location searched: crates.io index
required by package `chrono-tz v0.6.3`
    ... which satisfies dependency `chrono-tz = "^0.6.1"` (locked to 0.6.3) of package `async-graphql v4.0.10 ()`
    ... which satisfies path dependency `async-graphql` (locked to 4.0.10) of package `async-graphql-poem v4.0.10 ()`

which bewilders me

@raptros raptros changed the title define override directive field define override directive on fields Aug 19, 2022
@raptros
Copy link
Contributor Author

raptros commented Aug 19, 2022

was able to get it to build and test locally ... had to use stable 1.63, and also had to fix some mistakes in my tests

* define the directive field on the field struct
* implement printing it on the federation sdl
* update the derive stuff
* add a test
@raptros raptros marked this pull request as ready for review August 20, 2022 20:24
@sunli829
Copy link
Collaborator

Thanks! ♥

@sunli829 sunli829 merged commit 7b1c711 into async-graphql:master Aug 22, 2022
@raptros raptros deleted the add-overrides-directive branch August 22, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants