Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update federation docs with examples of each directive #1080

Merged
merged 7 commits into from
Sep 24, 2022
Merged

docs: Update federation docs with examples of each directive #1080

merged 7 commits into from
Sep 24, 2022

Conversation

dbanty
Copy link
Member

@dbanty dbanty commented Sep 22, 2022

This greatly expands the federation docs by adding examples of all the directives as well as links out to the Apollo docs for each of them.

I may have gone a little overboard with the amount of examples 馃槄 but I wanted it to be very easy for folks to find and add a federated directive when they need one 馃榿.

I didn't add all of the # ... lines to make the code compilable, so I'm guessing CI will fail. If it does, I'll go back and add those soon!

@sunli829
Copy link
Collaborator

Thanks a lot! 馃檪

@dbanty
Copy link
Member Author

dbanty commented Sep 23, 2022

I think I fixed all the issues in the examples so they pass tests now! 馃帀. Only remaining CI failures should be fixed by #1082

@sunli829 sunli829 merged commit 03c62df into async-graphql:master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants