Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade opentelemetry to 0.19.0 #1262

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

kenkoooo
Copy link
Contributor

@kenkoooo kenkoooo commented Mar 27, 2023

Since opentelemetry 0.19 is not compatible with 0.18, we need to update the dependency to use the OpenTelemetry extension with the latest opentelemetry crate.

We also need to fix the example repository after this PR is merged.

@kenkoooo
Copy link
Contributor Author

Please let me know if I missed something I needed to do before pushing a PR. Thanks!

@kenkoooo
Copy link
Contributor Author

kenkoooo commented Jun 1, 2023

@sunli829 Hello! It seems that you might not be interested in merging this change into your project. Would you like me to close this pull request?

@sunli829
Copy link
Collaborator

sunli829 commented Jun 7, 2023

Thanks a lot, it's not that I'm not interested, I'm busy with other things. 😂

@sunli829 sunli829 merged commit c0a5ca5 into async-graphql:master Jun 7, 2023
@kenkoooo kenkoooo deleted the feat/upgrade-opentelemetry branch June 16, 2023 07:10
@kenkoooo
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants