Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize space between Args, Lists and Binary items #1392

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

tusharmath
Copy link
Contributor

@tusharmath tusharmath commented Oct 6, 2023

Older implementation would not insert a whitespace after comma. This is generally quite a standard way to print lists, args and binary in GraphQL. This also works well with existing tools such as [prettier] and IDE's default formatter.

I have created a playground to try out prettier with different configurations.

@tusharmath tusharmath changed the title insert space after comma Insert space after comma Oct 6, 2023
@tusharmath tusharmath changed the title Insert space after comma Standardise space between Args, Lists and Binary items Oct 6, 2023
@tusharmath tusharmath changed the title Standardise space between Args, Lists and Binary items Standardize space between Args, Lists and Binary items Oct 6, 2023
@tusharmath tusharmath marked this pull request as ready for review October 6, 2023 12:06
@sunli829 sunli829 merged commit eb39af5 into async-graphql:master Feb 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants