Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date cursor precision string format #1462

Merged
merged 1 commit into from
Jan 21, 2024
Merged

fix: date cursor precision string format #1462

merged 1 commit into from
Jan 21, 2024

Conversation

ziimakc
Copy link
Contributor

@ziimakc ziimakc commented Jan 13, 2024

Sql databases (pg/mysql) timestamp precision is 6 subseconds digits max 2024-01-09T22:03:07.195000Z, which is also a default.

Using 3 subseconds digits precision for cursor date->string conversion will not match 2024-01-09T22:03:07.195Z != 2024-01-09T22:03:07.195000Z on database level which may result in shifted/incorrect pagination for some cases.

@Miaxos Miaxos self-requested a review January 16, 2024 10:08
@sunli829 sunli829 merged commit f514b58 into async-graphql:master Jan 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants