New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Warp WS Close, Ping, and Pong messages from being parsed as GraphQL #459

Merged

sunli829 merged 2 commits into async-graphql:master from D1plo1d:fix/warp-websocket-pings

Apr 1, 2021

Contributor

D1plo1d commented Apr 1, 2021 •

edited

Loading

This allows Web Socket clients to send pings to the Warp server in order to keep long lived connections alive.

Pings are supported by and automatically responded to by Tungstenite: https://docs.rs/tungstenite/0.13.0/tungstenite/enum.Message.html#variant.Ping

D1plo1d added 2 commits

March 31, 2021 19:40


          fix: Close, Ping, and Pong websocket messages should not be parsed as…

d8a9481

… GraphQL


          Fixed code formatting

c0a26bb

Collaborator

sunli829 commented Apr 1, 2021

Thank you so much! 😁

sunli829 merged commit 3b43472 into async-graphql:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment