Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#550: macros fixes for generic Context #562

Merged
merged 4 commits into from Jul 4, 2021
Merged

#550: macros fixes for generic Context #562

merged 4 commits into from Jul 4, 2021

Conversation

nicoulaj
Copy link
Contributor

@nicoulaj nicoulaj commented Jul 3, 2021

This fixes 2 small bugs in ComplexObject to allow generic typing of Context data. See unit test for example.

Fixes #550

@sunli829
Copy link
Collaborator

sunli829 commented Jul 4, 2021 •
edited

Thank you, I also added support for concrete types of ComplexObject.

async-graphql/tests/complex_object.rs

Line 142 in 1d2b331

pub async fn test_complex_object_with_generic_concrete_type() {

@sunli829 sunli829 merged commit 1d2b331 into async-graphql:master Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] Generics and context
2 participants
@nicoulaj @sunli829