-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cbor #619
Add support for cbor #619
Conversation
misc: boxed error
Related issue: #569 |
Thank you very much, it looks great! 🙂 |
forgot to format that i guess |
I will solve it, and I will add a feature called |
seems like a good idea 👍 |
please note that clippy probably will still fail, because this fork was created before c4cfa24
Should I merge your master into our fork so clippy passes(see latest commit comment)? |
Also I'm currently looking into the multipart code and there's a problem with multer: I want to reduce code duplication so here I want to reuse the The problem is that this (and actually all these) methods take |
Yes, you can deref https://docs.rs/futures/0.3.17/futures/io/trait.AsyncRead.html#impl-AsyncRead-for-%26%27_%20%5Bu8%5D |
I have merged into the |
You can create a new PR to continue to improve. 🙂 |
I'll do 👍 |
A while back we discussed the ability to use cbor as encoding. Back then, we got that to work and used it since on our fork. I thought that we could make a PR too.
Note
We use it to build a graphql server and haven't encountered any errors yet. Multipart (for the file upload extension) probably won't work just yet, because it still uses serde_json.