Supported CharsMinLength and CharsMaxLength to limit multibyte characters properly #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…count chars, not byte len.
|
Thank you! But I think |
|
it's also good i think 😃 |
|
Shall I write it? |
Of course, if you want. 🙂 |
…ngth to count chars, not byte len." This reverts commit b4116cd.
|
done 🙂 |
smihica
changed the title
|
Thanks!😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
I supported multibyte string in StringMinLength and StringMaxLength.
It originally counted byte length of the String (Is it intended?)
I'm not sure but I thought it is natural counting chars len in the String than bytes len in the String.
because basically JSON String is utf-8 encoded multibyte string.
Thank you