Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit interfaces not being exposed via the __schema introspection #741

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

urkle
Copy link
Contributor

@urkle urkle commented Dec 4, 2021

This fixes implicit interfaces not being exposed in introspection as they used to in version 2.x.

Fixes #740

@urkle urkle changed the title Add tests and try to fix the implicit interfaces not being exposed via the __schema API Fix implicit interfaces not being exposed via the __schema API Dec 5, 2021
@urkle urkle changed the title Fix implicit interfaces not being exposed via the __schema API Fix implicit interfaces not being exposed via the __schema introspection Dec 5, 2021
If an interface is added manually (as it is not directly referenced by any type) it was not showing up in the introspection.

Now it will be exposed if it is visible and references already accessible types
@sunli829 sunli829 merged commit cde3a7c into async-graphql:master Dec 5, 2021
@sunli829
Copy link
Collaborator

sunli829 commented Dec 5, 2021

Thank you very much, this bug is hard to find. 🙂

@urkle urkle deleted the fix-interfaces branch May 31, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interfaces not being exported via schema in Async GraphQL 3.x
2 participants