Actix integration: cbor response support + error handling improvements #784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
.unwrap()
from theResponder
impl for GraphQLResponse, instead opting to act the same way Actix'sJson
responder does it: https://docs.rs/actix-web/4.0.0-beta.20/src/actix_web/types/json.rs.html#119-137Accept
header and acting based on the mime type in there.I'm not 100% sure if this PR is in a mergable state, I could feature-flag the whole cbor thing or split this up into two PRs if that's preferred.
I've also noticed that the cbor request implementation doesn't actually support the
application/cbor
mime type atm, the stated reason being thatmime
doesn't support it yet; howevermime
is unmaintained and will never add it, and also it's possible to match on(mime::APPLICATION, "cbor")
without the crate needing to add support. That's definitely a separate PR however (and I don't need cbor requests, so I'm not sure if I'm the right person to implement that).