Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS issue for uploading image to Post in demo app #135

Closed
klyburke opened this issue Nov 30, 2020 · 4 comments
Closed

CORS issue for uploading image to Post in demo app #135

klyburke opened this issue Nov 30, 2020 · 4 comments
Assignees
Labels
Ready to test - Async Issue is implemented and ready for testing. PR is merged.

Comments

@klyburke
Copy link
Member

klyburke commented Nov 30, 2020

@tima101 Noting to ourselves that in the current demo app, a user is unable to add an image to a Post due to a CORS problem.

Access to fetch at 'https://saas-api.builderbook.org/api/v1/team-member/aws/get-signed-request-for-upload-to-s3' from origin 'https://saas-app.builderbook.org' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Screen Shot 2020-11-30 at 4 46 47 AM


Click to see Hill for issue #135
Single issue hill
Click to see Hill for all issues
All issue hill

created by Async

@tima101 tima101 added the Assigned - Async Issue is assigned to at least one person. PR is assigned to at least one person. label Nov 30, 2020
@klyburke klyburke self-assigned this Nov 30, 2020
@tima101
Copy link
Member

tima101 commented Dec 7, 2020

@klyburke Image upload works on YourSettings page, meaning it is not S3 problem and not cors Express middleware problem, must be problem in Post-related code. I will report here when I find out.

@tima101
Copy link
Member

tima101 commented Dec 8, 2020

@klyburke Pushed fix
83fa735
f4c89cb

One of env var was not available on the browser.
Let's keep it open until I make fix in the book's content.

@tima101
Copy link
Member

tima101 commented Feb 4, 2021

@klyburke Solved.

@tima101 tima101 added Ready to test - Async Issue is implemented and ready for testing. PR is merged. and removed Assigned - Async Issue is assigned to at least one person. PR is assigned to at least one person. labels Feb 4, 2021
@klyburke
Copy link
Member Author

klyburke commented Feb 4, 2021

I confirm that image upload in a Post is working now. Thanks!

@klyburke klyburke closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to test - Async Issue is implemented and ready for testing. PR is merged.
Projects
None yet
Development

No branches or pull requests

2 participants