Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extension_trait #1006

Merged
merged 11 commits into from
Mar 16, 2022
Merged

Remove extension_trait #1006

merged 11 commits into from
Mar 16, 2022

Commits on Mar 10, 2022

  1. Remove unused parameter from extension_trait! rules. 

    Two of the rules have `(+ $lt:lifetime)?` that is not used on the RHS
and serves no useful purpose. This commit removes it.
    @nnethercote
    nnethercote committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    e19ab62 View commit details
    Browse the repository at this point in the history

  2. Remove unused borrowed module.

    @nnethercote
    nnethercote committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    f56a8d6 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Remove docs-only features from extension_trait. 

    This is the `@doc` rules, the shim trait impls, and the imports.
    @nnethercote
    nnethercote committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    ed2fcce View commit details
    Browse the repository at this point in the history

  2. Simplify the first trait in extension_trait. 

    The body and doc comment are no longer used.
    @nnethercote
    nnethercote committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    c10d2d3 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary types in extension_trait. 

    The remaining type requires the square brackets (for now) because a `ty`
cannot immediately precede a `$(tt)*`.
    @nnethercote
    nnethercote committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    6b3667d View commit details
    Browse the repository at this point in the history

  4. Move the blanket impl outside of extension_trait.

    @nnethercote
    nnethercote committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    c626a69 View commit details
    Browse the repository at this point in the history

  5. Move the base trait re-export outside of extension_trait.

    @nnethercote
    nnethercote committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    1c70420 View commit details
    Browse the repository at this point in the history

  6. Remove what's left of the first trait in extension_trait.

    @nnethercote
    nnethercote committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    2dde882 View commit details
    Browse the repository at this point in the history

  7. Remove extension_trait. 

    At this point, `extension_trait` is basically an expensive no-op. This
commit removes it. The next commit will adjust the indentation.
    @nnethercote
    nnethercote committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    1146c66 View commit details
    Browse the repository at this point in the history

  8. Reindent de-macrofied code. 

    This commit only affects whitespace; `git diff -w` for it is empty.
    @nnethercote
    nnethercote committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    01ede03 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Use the default recursion_limit. 

    Now that `extension_trait!` is gone, an increased limit isn't necessary.
    @nnethercote
    nnethercote committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    cca0f3e View commit details
    Browse the repository at this point in the history