Update futures-preview to 0.3.0-alpha.19 #255
Conversation
|
Would this be a breaking change and require async-std to be bumped to 0.100.0? |
|
@tomaka Since the major version of async-std is 0, we will actually need to increase the minor version (if we follow semver). Also, I believe https://github.com/async-rs/async-std/pull/239/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR39-R40 was a breaking change. |
| @@ -48,11 +48,11 @@ broadcaster = { version = "0.2.6", optional = true, default-features = false, fe | |||
| femme = "1.2.0" | |||
| surf = "1.0.2" | |||
| tempdir = "0.3.7" | |||
| futures-preview = { version = "=0.3.0-alpha.19", features = ["async-await"] } | |||
There was a problem hiding this comment.
We can also drop the async-await feature, we don't need it anymore.
There was a problem hiding this comment.
I think examples/a-chat is still using it.
async-std/examples/a-chat/client.rs
Line 1 in 5881d9a
There was a problem hiding this comment.
Right, in this case, we should keep it.
|
@taiki-e I can't quite figure out why this is a draft, is there anything missing? |
|
@skade This PR is marked as a draft because it depends on other PR (http-rs/surf#74, But, I'm not sure if this is the correct usage of the draft). Everything else is ready. |
|
In this case, I think we should deactivate the surf example temporarily in this case and merge it. |
|
@skade Done. |
|
bors r+ |
255: Update futures-preview to 0.3.0-alpha.19 r=skade a=taiki-e Depends on http-rs/surf#74 Refs: * rust-lang/futures-rs#1761 * rust-lang/futures-rs#1845 cc @skade @stjepang @yoshuawuyts Co-authored-by: Taiki Endo <te316e89@gmail.com>
Build failed
|
|
Oops, sorry, I forgot to remove the patch. (It has been fixed in the latest commit.) |
|
Fixed and CI passed. |
|
bors r+ |
255: Update futures-preview to 0.3.0-alpha.19 r=skade a=taiki-e Depends on http-rs/surf#74 Refs: * rust-lang/futures-rs#1761 * rust-lang/futures-rs#1845 cc @skade @stjepang @yoshuawuyts Co-authored-by: Taiki Endo <te316e89@gmail.com>
Build succeeded
|
Depends on http-rs/surf#74
Refs:
cc @skade @stjepang @yoshuawuyts