Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of unstable format_code_in_doc_comments option #685

Merged
1 commit merged into from
Jan 20, 2020
Merged

Remove usage of unstable format_code_in_doc_comments option #685

1 commit merged into from
Jan 20, 2020

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Jan 20, 2020

fix build fail in #677

based on: #677 (comment)

  • this option is unstable
  • (AFAIK) many docs with examples of this crate are in macros and rustfmt doesn't format code in macros, so are the benefits of using this option in this crate should not be very big.

related: #515 (review)

I'm (pleasantly) surprised that only two tests had to be reformatted :)

this may be because of the few places where it can be applied...

ghost
ghost approved these changes Jan 20, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame we can't use this option anymore, but oh well... :/

Thanks for fixing this!

@ghost ghost merged commit 6b860c3 into async-rs:master Jan 20, 2020
@taiki-e taiki-e deleted the fmt branch January 20, 2020 23:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@taiki-e