Add cargo features "client" and "server" #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Since many consumers of this library do not need both client and server features, this allows them to shrink their dependencies somewhat.
|
Seems unrelated. I'm going to check that locally. |
This was incorrect. Because rustls depends on webpki, server applications would still need to build that crate, though they would no longer need to build webpki-roots. |
|
Added documentation to the README and merged. Thanks @mbrubeck ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since many consumers of this library do not need both client and server features, this allows them to shrink their dependencies somewhat.
In particular, server applications would no longer need to build the unused
webpki andwebpki-roots crate.I would also suggest making these features disabled by default in a future version, to increase the likeliness that consumers will choose the features they actually need. (This would be a breaking change.)