Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placeholder splitting #21

Closed
wants to merge 1 commit into from
Closed

Fix placeholder splitting #21

wants to merge 1 commit into from

Conversation

gerriet-hinrichs
Copy link

Update splitting by not just simply using the placeholder itself but by making it context aware:

  • Handle cases where the trailing semicolon is removed
  • Handle cases where minification merged a required semicolon with the one from the placeholder

Fixes #18 and #20

Update splitting by not just simply using the placeholder itself but by making it context aware:
- Handle cases where the trailing semicolon is removed
- Handle cases where minification merged a required semicolon with the one from the placeholder

Fixes #18 and #20
@coveralls
Copy link

Pull Request Test Coverage Report for Build 69

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.057%

Totals Coverage Status
Change from base Build 63: 0.2%
Covered Lines: 85
Relevant Lines: 92

💛 - Coveralls

@asyncLiz
Copy link
Owner

Thanks for the PR! I appreciate the contribution 🙂

The underlying issue for this has actually already been solved as part of the html template adjusting the CSS minify options to compensate for the semicolon being removed from the placeholder.

The same logic is not being applied to the css template minify options. I've created #22 that should address that issue and fix the two issues you've created.

Because of that, I'm going to go ahead and close this PR in favor of the other one. But thank you again for the detailed test cases and issues!

@asyncLiz asyncLiz closed this Aug 18, 2020
@gerriet-hinrichs gerriet-hinrichs deleted the fix-placeholder-splitting branch August 18, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS minify doesn't work with blocks ending with a template variable
3 participants