This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
feat: repurpose as Studio design system only #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmvilas
requested review from
mcturco,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for enchanting-cascaron-aa83e8 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Closed
|
@mcturco @magicmatatjahu would you mind having a look? If you agree, we can merge it and move forward :) |
mcturco
approved these changes
Apr 3, 2023
|
/rtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to propose that we get rid of all the design system initiatives except the one for Studio. I don't think anyone is interested in working on a website design system but if someone does in the future, we can explore adding Lerna here or simply another repo instead.
That said, I think we can include the design system of the Docs UI as part of the Studio design system for now and we'll split it in the future if it makes sense.
In general, I'm trying to simplify this repo and make it easier to move forward. Let me know what you think.