Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links - references to parts of OAS specification? #3

Closed
MikeRalphson opened this issue May 16, 2017 · 5 comments
Closed

Broken links - references to parts of OAS specification? #3

MikeRalphson opened this issue May 16, 2017 · 5 comments
Labels

Comments

@MikeRalphson
Copy link
Contributor

Found by mdv, which runs as part of the OAS CI task.

{ source: 'README.md',
  missingAnchors:
   [ { name: 'componentsObject', defined: 0, seen: 1 },
     { name: 'dataTypeFormat', defined: 0, seen: 1 },
     { name: 'referenceObject', defined: 0, seen: 1 } ] }

Happy to raise a PR to add a CI step. I think all of the above need sections adding to the spec or links created to a version of the OAS spec?

@fmvilas
Copy link
Member

fmvilas commented May 16, 2017

Awesome, didn't know about mdv. A PR would be much appreciated.

@fmvilas
Copy link
Member

fmvilas commented May 16, 2017

And yes, it seems it's referencing some OAS part, but if I'm not wrong they are also applicable to AsyncAPI.

@MikeRalphson
Copy link
Contributor Author

componentsObject looks like it should have its own definition in the AsyncAPI spec as it has a different structure to the OAS object. Should the other two be links into OAS? If so, to which version/branch/tag?

@fmvilas
Copy link
Member

fmvilas commented May 17, 2017

IMO everything should be in the AsyncAPI document and not referencing OAS externally beacause the two specifications can evolve in a different way/pace. So I would just copy the missing pieces and paste them here. And in case it's different (like components object) we should redact its definition.

What do you think?

MikeRalphson added a commit to MikeRalphson/asyncapi that referenced this issue May 17, 2017
MikeRalphson added a commit to MikeRalphson/asyncapi that referenced this issue May 17, 2017
MikeRalphson added a commit to MikeRalphson/asyncapi that referenced this issue May 17, 2017
MikeRalphson added a commit to MikeRalphson/asyncapi that referenced this issue May 17, 2017
MikeRalphson added a commit to MikeRalphson/asyncapi that referenced this issue May 17, 2017
MikeRalphson added a commit to MikeRalphson/asyncapi that referenced this issue May 17, 2017
fmvilas added a commit that referenced this issue May 17, 2017
Add referenceObject section, refs #3
fmvilas added a commit that referenced this issue May 17, 2017
Add data type formats section, refs #3
fmvilas added a commit that referenced this issue May 17, 2017
Add componentsObject section, refs #3
@fmvilas
Copy link
Member

fmvilas commented May 17, 2017

@MikeRalphson it's working perfectly: https://travis-ci.org/asyncapi/asyncapi

Thanks man 👏

@fmvilas fmvilas closed this as completed May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants