feat: support required and validator attributes in avro files #82
Conversation
M3lkior
force-pushed
the
feat/18-support-extra-attributes
branch
2 times, most recently
from
08e9a8a
to
e78ebe9
Compare
| @@ -121,13 +182,18 @@ async function convertAvroToJsonSchema(avroDefinition, isTopLevel) { | |||
| case 'enum': | |||
| jsonSchema.enum = avroDefinition.symbols; | |||
| break; | |||
| case 'float': | |||
| case 'double': | |||
There was a problem hiding this comment.
I know this fall-through is intentional, but I think it should be marked/flagged as such - maybe a comment or something as a heads-up to the next person who makes changes here.
| case 'int': | ||
| case 'long': | ||
| case 'float': | ||
| case 'double': |
There was a problem hiding this comment.
I know this fall-through is intentional, but I think it should be marked/flagged as such - maybe a comment or something as a heads-up to the next person who makes changes here.
to-json-schema.js
Outdated
| setAdditionalAttribute('maximum'); | ||
| setAdditionalAttribute('exclusiveMinimum'); | ||
| setAdditionalAttribute('exclusiveMaximum'); | ||
| setAdditionalAttribute('multipleOf'); |
There was a problem hiding this comment.
Subjective style idea - a setAdditionalAttributes helper function that takes an array of strings would help simplify this bit.
setAdditionalAttributes(['minimum', 'maximum', 'exclusiveMinimum', ...
M3lkior
force-pushed
the
feat/18-support-extra-attributes
branch
from
cb1fc1d
to
1a849a5
Compare
- supports of required fields: required fields are field without default value or without a union containing the 'null' element - brings supports for additional attributes in avro file. See the README.MD for the list of supported attributes - also add the format precision for the double and float type by setting the format attribute in the json definition Closes asyncapi#17,asyncapi#18
Co-authored-by: Dale Lane <dale.lane@gmail.com>
M3lkior
force-pushed
the
feat/18-support-extra-attributes
branch
from
0de4e09
to
139c8bc
Compare
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!聽 聽
|
|
@dalelane is it ok for you too? can you approve? you had some comments |
|
馃帀 This PR is included in version 0.6.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
logicalTypeavro attributeClose #18
Description
I introduce a new
asyncapi-avro-1.9.0-additional-attributes.yamlto illustrate the supported attributes and to easily generate the specification from the CLI to see the result in the html template 馃憤Related issue(s)