Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata for some remaining commands #1431

Merged

Conversation

peter-rr
Copy link
Member

@peter-rr peter-rr commented May 16, 2024

Description
This PR will add metadata to the following commands:

  • asyncapi config analytics
  • asyncapi start studio
  • asyncapi new glee
  • asyncapi diff

Related issue(s)
Resolves #1357

@peter-rr peter-rr marked this pull request as ready for review May 22, 2024 20:38
src/commands/config/analytics.ts Show resolved Hide resolved
src/commands/diff.ts Show resolved Hide resolved
@peter-rr peter-rr requested a review from Amzani May 24, 2024 09:57
@peter-rr
Copy link
Member Author

peter-rr commented Jun 3, 2024

/ptal

@asyncapi-bot
Copy link
Contributor

@Souvikns @Shurtu-gal Please take a look at this PR. Thanks! 👋

Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peter-rr
Copy link
Member Author

peter-rr commented Jun 5, 2024

/rtm

@peter-rr
Copy link
Member Author

peter-rr commented Jun 5, 2024

/rtm

@peter-rr
Copy link
Member Author

peter-rr commented Jun 5, 2024

@Shurtu-gal
I just re-requested your review since the merging seems to be blocked due to "requested changes not addressed".

Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @peter-rr

@Shurtu-gal
Copy link
Collaborator

/u

@Shurtu-gal
Copy link
Collaborator

/rtm

Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Shurtu-gal
Copy link
Collaborator

/rtm

@asyncapi-bot asyncapi-bot merged commit 1499830 into asyncapi:master Jun 5, 2024
12 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[CLI] Add metadata for metrics collection in remaining commands
5 participants