feat: create new command for the react template #1476
Conversation
AayushSaini101
requested review from
Souvikns,
Amzani,
Shurtu-gal and
asyncapi-bot-eve
as code owners
| @@ -0,0 +1,33 @@ | |||
| asyncapi: 2.6.0 | |||
There was a problem hiding this comment.
@AayushSaini101 I suggest to target version 3 instead, as we want people to adopt it.
| "supportedProtocols": [ ] | ||
| }, | ||
| "dependencies": { | ||
| "@asyncapi/generator-react-sdk": "^0.2.25" |
There was a problem hiding this comment.
I recommend to pick last version of generator-react-sdk
https://github.com/asyncapi/generator-react-sdk/releases/tag/v1.0.20
| @@ -0,0 +1,21 @@ | |||
|
|
|||
There was a problem hiding this comment.
I'm not sure about the naming of this file and its purpose
There was a problem hiding this comment.
Removed thanks @Amzani
| import { Flags } from '@oclif/core'; | ||
|
|
||
| export const templateFlags = () => { | ||
| return { |
There was a problem hiding this comment.
I suggest to add also renderer flag as some people may use nunjucks, see: https://www.asyncapi.com/docs/tools/generator/template-development
|
Let's wait for other maintainers review as well @Shurtu-gal @Souvikns |
|
@Amzani Please review |
|
/rtm |
|
Hello, @AayushSaini101! 👋🏼 |
|
/rtm |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@asyncapi/bounty_team |
Resolves: #337