Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Oclif for conditional fields #334

Closed
jonaslagoni opened this issue Sep 13, 2022 · 3 comments
Closed

Upgrade Oclif for conditional fields #334

jonaslagoni opened this issue Sep 13, 2022 · 3 comments
Labels
enhancement New feature or request stale

Comments

@jonaslagoni
Copy link
Sponsor Member

Reason/Context

For the generate models command, there are specific arguments that must be provided based on the condition of the language output:

throw new Error('In order to generate models to C#, we need to know which namespace they are under. Add `--namespace=NAMESPACE` to set the desired namespace.');

This was previously not supported by Oclif but now it is: oclif/oclif#323

This means that we can remove those custom checks and instead make the check in Oclif directly.

Description

Upgrade Oclif and refactor generate models to use the new conditional checks.

@jonaslagoni jonaslagoni added the enhancement New feature or request label Sep 13, 2022
@Souvikns
Copy link
Member

Souvikns commented Nov 9, 2022

I don't think this helps in our case. So we enable packageName flag when we have java as an argument for language.Currently I can check only for flags and there is no support for checking arguments.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 10, 2023
@derberg
Copy link
Member

derberg commented Apr 3, 2023

I guess we can close, looking at the answer from @Souvikns

@jonaslagoni if you disagree please let us know and I will reopen

@derberg derberg closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

3 participants