Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: asyncApi files-scenarios link #27

Merged
merged 13 commits into from
Jul 8, 2021

Conversation

NektariosFifes
Copy link
Collaborator

@NektariosFifes NektariosFifes commented Jun 30, 2021

Description

  • Create association between asyncApi file and scenario file in order to aquire and structure all information needed to
    send and event to an endpoint.

Tested handling of:
async api and scenario file with wrong naming (only yaml and json files)
scenario file with wrong format not supported by the schema of the specified version
non existend asyncApi and scenario files

Related issue(s)
fixes #22

@NektariosFifes NektariosFifes marked this pull request as draft July 2, 2021 12:59
@NektariosFifes NektariosFifes changed the title AsyncApi files-scenarios link feat: AsyncApi files-scenarios link Jul 4, 2021
@NektariosFifes NektariosFifes changed the title feat: AsyncApi files-scenarios link feat: asyncApi files-scenarios link Jul 4, 2021
@NektariosFifes NektariosFifes marked this pull request as ready for review July 4, 2021 14:13
@NektariosFifes
Copy link
Collaborator Author

NektariosFifes commented Jul 4, 2021

@jonaslagoni i think it is ready

Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some general comments and suggestions 🙂 👍

Be very careful about creating function names such as verifyInput_ParseAndLinkFiles as they can grow undesirably long 😄

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/parser/scenarioParserAndConnector.js Outdated Show resolved Hide resolved
src/parser/scenarioParserAndConnector.js Outdated Show resolved Hide resolved
src/parser/scenarioParserAndConnector.js Outdated Show resolved Hide resolved
src/parser/scenarioParserAndConnector.js Outdated Show resolved Hide resolved
src/parser/scenarioParserAndConnector.js Show resolved Hide resolved
src/parser/scenarioParserAndConnector.js Show resolved Hide resolved
src/parser/scenarioParserAndConnector.js Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonaslagoni jonaslagoni merged commit a49e21d into asyncapi:master Jul 8, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@NektariosFifes NektariosFifes deleted the AsyncApi_Scenario_Link branch July 9, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the link between asyncApi spec file and simPlot file
3 participants