Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce parser and cli #5

Merged
merged 33 commits into from
Jun 28, 2021

Conversation

NektariosFifes
Copy link
Collaborator

@NektariosFifes NektariosFifes commented Apr 19, 2021

Description

  • Basic cli functionality.
  • eslint and added related npm packages
  • initialized readme
  • Input loop to make sure the user provides a correctly formated ,and existent async api File

Related issue(s)
#18

@jonaslagoni jonaslagoni added this to To do in Project board Apr 19, 2021
@jonaslagoni jonaslagoni moved this from To do to In progress in Project board Apr 19, 2021
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from here, great job man 👍. @jonaslagoni you might wanna review this PR

Async-Simulator/README.md Outdated Show resolved Hide resolved
Async-Simulator/src/cliUI/LoadingBar.js Outdated Show resolved Hide resolved
@jonaslagoni
Copy link
Sponsor Member

@NektariosFifes whenever the PR is ready to be reviewed you can select reviewers to the right side of this PR which sends a request to me that I should take a look at it. This is great in some cases where last-minute changes are still needed before it is getting reviewed, otherwise you can always create the PR as a draft which marks the PR as in progress.

Is it ready to be reviewed? 😄

@NektariosFifes
Copy link
Collaborator Author

@NektariosFifes whenever the PR is ready to be reviewed you can select reviewers to the right side of this PR which sends a request to me that I should take a look at it. This is great in some cases where last-minute changes are still needed before it is getting reviewed, otherwise you can always create the PR as a draft which marks the PR as in progress.

Is it ready to be reviewed? 😄

nope

@NektariosFifes
Copy link
Collaborator Author

@jonaslagoni if you want u can review pr

Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So left quite a few comments in multiple locations, but generally, it looks good 👍 🙂

A few general comments:

  • Why have you created the Async-Simulator folder? 🤔 I think we can unwrap this right?
  • Any files that are not used at the moment, this includes empty files, UI library files (if they are not used in the CI at the moment, should be removed from this PR. Feel free to save them on another branch 🙂
  • Keep referring to the library as Fluffy Robot, at least until another name is found, this is to ensure consistency when referenced

Let me know if you have any questions about my comments, and ensure you evaluate my comments and not just blindly accept them as you might have a different opinion or know something I dont 🙂

.gitignore Outdated Show resolved Hide resolved
Async-Simulator/Dockerfile Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Async-Simulator/.gitignore Outdated Show resolved Hide resolved
Async-Simulator/src/bin/cli.js Outdated Show resolved Hide resolved
Async-Simulator/package.json Outdated Show resolved Hide resolved
Async-Simulator/package.json Outdated Show resolved Hide resolved
Async-Simulator/package.json Outdated Show resolved Hide resolved
Async-Simulator/simulator.sh Outdated Show resolved Hide resolved
Async-Simulator/src/bin/dockerCli.js Outdated Show resolved Hide resolved
@NektariosFifes
Copy link
Collaborator Author

ok i think i fixed them :) @jonaslagoni

Copy link

@akhill10 akhill10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mate ! Few changes requested, have a look it. 🙂

src/bin/cli.js Outdated Show resolved Hide resolved
src/bin/cli.js Outdated Show resolved Hide resolved
src/bin/cli.js Outdated Show resolved Hide resolved
src/bin/cli.js Outdated Show resolved Hide resolved
src/bin/cli.js Outdated Show resolved Hide resolved
src/parser/AsyncParser.js Outdated Show resolved Hide resolved
src/bin/cli.js Outdated Show resolved Hide resolved
src/parser/AsyncParser.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jonaslagoni
Copy link
Sponsor Member

Our CI system requires you to name the title of the PR something like feat: simulation lib for it properly understand it. Maybe a better title would be feat: introduce parser and cli?

@NektariosFifes NektariosFifes changed the title Simulation lib feat: introduce parser and cli Jun 25, 2021
Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some more comments 👍

Almost there 🎉

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/Schema/SimulationPlotSchema_0.0.1+yaml.json Outdated Show resolved Hide resolved
src/bin/cli.js Outdated Show resolved Hide resolved
src/parser/AsyncParser.js Outdated Show resolved Hide resolved
src/bin/cli.js Outdated Show resolved Hide resolved
src/bin/cli.js Outdated Show resolved Hide resolved
src/parser/AsyncParser.js Outdated Show resolved Hide resolved
src/parser/index.js Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 🎉

Only a final touchup, please go through all the dependencies and remove any that are unused 🙂

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/bin/cli.js Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you update package-lock.json and commit it after the last dependencies have been assessed 🙂

package.json Outdated Show resolved Hide resolved
@jonaslagoni
Copy link
Sponsor Member

@NektariosFifes you have two lint errors that have to be dealt with 🙂 The security lint warning can be disabled I think 🤔

Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last suggestion and lets merge 👍

src/index.js Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job! 👍

@jonaslagoni jonaslagoni merged commit a118243 into asyncapi:master Jun 28, 2021
Project board automation moved this from In progress to Done Jun 28, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants