fix: wrong references crashes library

[jonaslagoni]

Description
This PR improves the maintainability for input processosr by only moving from integration test to unit test as well as fixing a bug that crashes the library if references are wrong

Related issue(s)
Related to #64

[jonaslagoni]

@derberg I would really like for coveralls to give me an indication here, to ensure that the coverage did not drop with these test changes. (I checked manually, but reviewer have no idea)

Can we try switching from trigger pull_request_target to pull_request? 🤔

[coveralls]

Coverage increased (+0.06%) to 94.645% when pulling 97e1098 on jonaslagoni:feature/rework_process_test into e41ca23 on asyncapi:master.

[jonaslagoni]

Alright then, coveralls are just a 🐢.

[derberg]

It works 🎉
🤝 congrats

Happy with the solution so far? I guess we need a couple of weeks of testing before we roll it out to others?

Check test coverage / Build should be made mandatory.

if we would have pull_request, the bot would have no right to make the comment that you can see above

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.1% Duplication

[magicmatatjahu]

LGTM :)

[jonaslagoni]

if we would have pull_request, the bot would have no right to make the comment that you can see above

@derberg I played around with switching between pull_request and pull_request_target. And the comment is not updated (the bot update the comment when commits are pushed) when we are using pull_request_target. In order for the bot to write on PR's we have to use pull_request. As I have switched to currently.

[derberg]

And the comment is not updated (the bot update the comment when commits are pushed)

I don't get it, you mean the comment from coveralls bot showed up only when you were using pull_request?

[jonaslagoni]

I don't get it, you mean the comment from coveralls bot showed up only when you were using pull_request?

@derberg Yes, I have switched back and forth figuring out when it updates the comment. I tried to switch here f0514ed
and I assume that only then the bot comment showed up. Also why use pull_request_target if the user can switch to pull_request and it runs anyway 🤷

[derberg]

it runs, it will be, but GITHUB_TOKEN has only read rights as when user changes to pull_request then the workflow file is taken from the fork, and token has read rights only to not enable token leaking. pull_request_target means that on PR, workflow is taken from master (default branch) and therefore token has more privileges as it cannot be leaked.

This is why it is super confusing for me, that pull_request works and bot makes comment 🤷🏼 magic 😄 or the coveralls bot just like sonarcloud bot are completely separate from the workflow, they work independently. So yeah, if pull_request works, then just merge 😄 and I put this case into my x-files box of unsolved cases and someday talk to Mulder and Scully to help me out figuring out what was wrong 😆

[asyncapi-bot]

🎉 This PR is included in version 0.6.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀