refactor: items interpretation #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/models/CommonModel.ts
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
# Conflicts: # src/models/CommonModel.ts
jonaslagoni
changed the title
magicmatatjahu
previously approved these changes
May 20, 2021
# Conflicts: # docs/interpretation_of_JSON_Schema_draft_7.md
|
Kudos, SonarCloud Quality Gate passed!
|
|
Solved merge conflict and added missing interpreter integration 🤦 |
magicmatatjahu
approved these changes
May 20, 2021
|
Thanks! |
|
🎉 This PR is included in version 0.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the refactoring of the interpretation for
items.It changes the entire perspective, to instead of adding simplification functions per CommonModel property, we process the JSON Schema keywords which then affects the CommonModel in some way.
It adds
itemsschema keyword.Files this PR is supposed to replace
Todo
Related issue(s)
Blocked by #184