Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve arborist (npm installation) to have no hacks #1102

Open
derberg opened this issue Jan 17, 2024 · 4 comments · May be fixed by #1115
Open

Improve arborist (npm installation) to have no hacks #1102

derberg opened this issue Jan 17, 2024 · 4 comments · May be fixed by #1115
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers stale

Comments

@derberg
Copy link
Member

derberg commented Jan 17, 2024 •
edited

use this PR as inspiration, except for:

  • no changes to workflows
  • arborist version should not be changed by this issue
  • supported engines should not be changed by this issue

What you need to do:

  • just ad pacote dependency
  • cleanup mocks and add new one - like in linked PR
  • modify generator.js as it is done in linked PR
@derberg derberg added the enhancement New feature or request label Jan 17, 2024
@derberg
Copy link
Member Author

derberg commented Jan 22, 2024

/gfi js

@asyncapi-bot asyncapi-bot added area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Jan 22, 2024
@AayushSaini101
Copy link
Contributor

I am on it

@derberg
Copy link
Member Author

derberg commented Jan 25, 2024

@AayushSaini101 thanks

@akkshitgupta akkshitgupta linked a pull request Feb 6, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: add pacote to resolve template name instead of arborist workaround akkshitgupta/generator
3 participants
@derberg @AayushSaini101 @asyncapi-bot