Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially supported image w/ generator + bundle of officially supported templates #587

Closed
andrew-j-roberts opened this issue May 10, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@andrew-j-roberts
Copy link

andrew-j-roberts commented May 10, 2021

Reason/Context

If you want to run the generator in an environment with restricted internet access, one of the ways to do that currently is to build the image of the generator & then provide it the local/absolute path to the template it should use.

It'd be easier to get up and running if there was an officially supported image of the generator that included an exhaustive bundle of all the versions of the officially supported templates, or if that'd be too large size wise maybe just the latest versions of them.

Description

  • What changes have to be introduced?
    There would need to be a build step introduced to releases that would build an image w/ the latest version of the generator and all the officially supported templates.

  • How could it be implemented/designed?
    This issue is similar and would provide a more granular solution to the end goal of this feature request—running the generator in an internet restricted environment, but I think this feature request can stand on its own. An officially supported image would be more convenient and lower the barrier to usage.

@andrew-j-roberts andrew-j-roberts added the enhancement New feature or request label May 10, 2021
@github-actions
Copy link
Contributor

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented May 12, 2021

I'm wondering if we should provide a huge docker image with all template, or maybe rather have setup in all templates, so they not only release npm packages but also a docker image with latest compatible generator and the template?

the problem with having one big bundle on generator repo will cause a situation that it will be quickly outdated and contain only old versions of the template. I mean, generator is not released that frequently, so the official docker image with all the templates can have templates in pretty old versions.

Do you know where I'm getting with my reasoning?

@andrew-j-roberts
Copy link
Author

andrew-j-roberts commented May 13, 2021

Hey @derberg, I do know what you're getting at and from my POV what you suggest is a more elegant solution. Would be interested to hear what others think as well.

I put together a sample repository here that includes a Dockerfile and Github Action for creating a composite image from the generator and a template. Nothing crazy, the generator supports using globally installed templates so it's just one more npm i -g command.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Jul 13, 2021
@magicmatatjahu magicmatatjahu removed enhancement New feature or request stale labels Jul 13, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Sep 12, 2021
@derberg derberg removed the stale label Sep 13, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jan 12, 2022
@derberg derberg added enhancement New feature or request and removed stale labels Jan 12, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label May 13, 2022
@derberg derberg removed the stale label May 16, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added stale and removed stale labels Sep 14, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jan 14, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2023
@derberg derberg removed the stale label Jul 5, 2023
@derberg
Copy link
Member

derberg commented Jul 5, 2023

keeping it closed, if you still need it, keep in mind we will be deprecating ag CLI and all work is now in https://github.com/asyncapi/cli. So if you still need it, please open new issue in new repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants