Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generalize Kafka properties #16

Merged
merged 7 commits into from
Apr 26, 2020

Conversation

Tenischev
Copy link
Member

Description

  • use properties from spring-kafka lib instead of custom
  • move properties to template parameters
  • update README with examples

Related issue(s)
Resolves #9

Tenischev and others added 3 commits April 25, 2020 19:12
* fix api calls for mqtt and amqp

* fix port variables

* feat: add annotations to the model generation (asyncapi#12)

* WIP, update to spec 2.0

* WIP, update to spec 2.0, remove definition of topic via extension

* working version for api 2.0

* add model generation

* Add support of Kafka generation

* update readme

* fix value ref, add jackson lib

* add validation annotations to schema

* fix no type case

* add annotation for jackson

* add description and examples to javadoc

* Update readme, move missed features block

* switch publish to subscribe and vice versa, because of wrong understanding of spec

* Fix consumed key, add key to publish operation

* move jackson and validation dependencies from kafka block

* fix README formatting

* mark annotations as done in README

* add support of multi-line description

* fix json in examples

* chore(release): 0.5.0 (asyncapi#15)

chore(release): 0.5.0

* fix api calls for mqtt and amqp

* fix port variables

* fix yet another api operation call

Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com>
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍

@fmvilas
Copy link
Member

fmvilas commented Apr 26, 2020

Can't merge because the branch has conflicts.

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmvilas fmvilas merged commit 5c1062f into asyncapi:master Apr 26, 2020
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

fmvilas pushed a commit that referenced this pull request Apr 26, 2020
* feat: add descriptions as javadocs over generated code

* fix: generation for mqtt and amqp (#14)

* fix api calls for mqtt and amqp

* fix port variables

* feat: add annotations to the model generation (#12)

* WIP, update to spec 2.0

* WIP, update to spec 2.0, remove definition of topic via extension

* working version for api 2.0

* add model generation

* Add support of Kafka generation

* update readme

* fix value ref, add jackson lib

* add validation annotations to schema

* fix no type case

* add annotation for jackson

* add description and examples to javadoc

* Update readme, move missed features block

* switch publish to subscribe and vice versa, because of wrong understanding of spec

* Fix consumed key, add key to publish operation

* move jackson and validation dependencies from kafka block

* fix README formatting

* mark annotations as done in README

* add support of multi-line description

* fix json in examples

* chore(release): 0.5.0 (#15)

chore(release): 0.5.0

* fix api calls for mqtt and amqp

* fix port variables

* fix yet another api operation call

Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com>

* chore(release): 0.5.1 (#19)

chore(release): 0.5.1

* feat: generalize Kafka properties (#16)

* feat: generalize kafka properties. use spring-kafka props inst.of custom, move props to template params

* fix wrong param name in example

* fix: generation for mqtt and amqp (#14)

* fix api calls for mqtt and amqp

* fix port variables

* feat: add annotations to the model generation (#12)

* WIP, update to spec 2.0

* WIP, update to spec 2.0, remove definition of topic via extension

* working version for api 2.0

* add model generation

* Add support of Kafka generation

* update readme

* fix value ref, add jackson lib

* add validation annotations to schema

* fix no type case

* add annotation for jackson

* add description and examples to javadoc

* Update readme, move missed features block

* switch publish to subscribe and vice versa, because of wrong understanding of spec

* Fix consumed key, add key to publish operation

* move jackson and validation dependencies from kafka block

* fix README formatting

* mark annotations as done in README

* add support of multi-line description

* fix json in examples

* chore(release): 0.5.0 (#15)

chore(release): 0.5.0

* fix api calls for mqtt and amqp

* fix port variables

* fix yet another api operation call

Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com>

* chore(release): 0.5.1 (#19)

chore(release): 0.5.1

* feat: generalize kafka properties. use spring-kafka props inst.of custom, move props to template params

* fix wrong param name in example

Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com>

* chore(release): 0.6.0 (#20)

chore(release): 0.6.0

* feat: add descriptions as javadocs over generated code

Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize Kafka properties
3 participants