-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add descriptions as javadocs over generated code #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix api calls for mqtt and amqp * fix port variables * feat: add annotations to the model generation (asyncapi#12) * WIP, update to spec 2.0 * WIP, update to spec 2.0, remove definition of topic via extension * working version for api 2.0 * add model generation * Add support of Kafka generation * update readme * fix value ref, add jackson lib * add validation annotations to schema * fix no type case * add annotation for jackson * add description and examples to javadoc * Update readme, move missed features block * switch publish to subscribe and vice versa, because of wrong understanding of spec * Fix consumed key, add key to publish operation * move jackson and validation dependencies from kafka block * fix README formatting * mark annotations as done in README * add support of multi-line description * fix json in examples * chore(release): 0.5.0 (asyncapi#15) chore(release): 0.5.0 * fix api calls for mqtt and amqp * fix port variables * fix yet another api operation call Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com>
chore(release): 0.5.1
fmvilas
approved these changes
Apr 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🙌
This branch has conflicts too. |
* feat: generalize kafka properties. use spring-kafka props inst.of custom, move props to template params * fix wrong param name in example * fix: generation for mqtt and amqp (asyncapi#14) * fix api calls for mqtt and amqp * fix port variables * feat: add annotations to the model generation (asyncapi#12) * WIP, update to spec 2.0 * WIP, update to spec 2.0, remove definition of topic via extension * working version for api 2.0 * add model generation * Add support of Kafka generation * update readme * fix value ref, add jackson lib * add validation annotations to schema * fix no type case * add annotation for jackson * add description and examples to javadoc * Update readme, move missed features block * switch publish to subscribe and vice versa, because of wrong understanding of spec * Fix consumed key, add key to publish operation * move jackson and validation dependencies from kafka block * fix README formatting * mark annotations as done in README * add support of multi-line description * fix json in examples * chore(release): 0.5.0 (asyncapi#15) chore(release): 0.5.0 * fix api calls for mqtt and amqp * fix port variables * fix yet another api operation call Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com> * chore(release): 0.5.1 (asyncapi#19) chore(release): 0.5.1 * feat: generalize kafka properties. use spring-kafka props inst.of custom, move props to template params * fix wrong param name in example Co-authored-by: asyncapi-bot <61865014+asyncapi-bot@users.noreply.github.com>
chore(release): 0.6.0
# Conflicts: # template/src/main/resources/application.yml
🎉 This PR is included in version 0.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Resolves: #17