feat: add support for additionalProperties (#272) #273
Conversation
JapuDCret
requested review from
Tenischev,
derberg and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
JapuDCret
changed the title
JapuDCret
changed the title
|
Hi @JapuDCret |
|
Is there any update? |
filters/all.js
Outdated
| return 'Map<String, ' + _.upperFirst(_.camelCase(prop.additionalProperties().uid())) + '>'; | ||
| } else if (prop.additionalProperties().format()) { | ||
| return 'Map<String, ' + toClass(toJavaType(prop.additionalProperties().format())) + '>'; | ||
| } else { |
There was a problem hiding this comment.
additionalProperties could be boolean true|false. This else will lead to strange consequence
| private @Valid Map<String, {{prop.additionalProperties().uid() | camelCase | upperFirst}}> {{propName | camelCase}}; | ||
| {%- elif prop.additionalProperties().format() %} | ||
| private @Valid Map<String, {{prop.additionalProperties().format() | toJavaType | toClass}}> {{propName | camelCase}}; | ||
| {%- else %} |
There was a problem hiding this comment.
additionalProperties could be boolean true|false. This else will lead to
Unable to call the return value of (prop["additionalProperties"])["type"], which is undefined or falsey
template/src/main/java/com/asyncapi/model/$$objectSchema$$.java
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
# Conflicts: # template/src/main/java/com/asyncapi/model/$$message$$.java # tests/__snapshots__/kafka.test.js.snap # tests/__snapshots__/mqtt.test.js.snap
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
additionalPropertiesto aMap<String, type>Related issue(s)
Resolves #272
Resolves #322