Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update template for spring boot 3 #313

Merged
merged 6 commits into from Sep 4, 2023

Conversation

Tenischev
Copy link
Member

@Tenischev Tenischev commented Jun 17, 2023

Description

Since spring boot 3 released some adjustments are required across template

For backward compatibility and users sake parameter springBoot2 created.

Related issue(s)
Resolves #296
Resolves #297
Resolves #318

Copy link

@jbiscella jbiscella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that if you remove 'List' at the end of line 29, 31, 33

you remove + 'List' at line 102, 132 , 162, 168 and 174

you would fix the bug raised as per #296

To reproduce the bug you can add the @NotNull annotation to a list and execute the validation

@jbiscella
Copy link

Also wondering if could be a sensible advise to add the @generated annotation to all the classes to ease configuring sonar to exclude them from the checks... could be a separate feature request probably

https://docs.oracle.com/javase/8/docs/api/javax/annotation/Generated.html

@Tenischev
Copy link
Member Author

Hi @jbiscella
I would not address @generated in this PR, because intention of this PR is to support spring boot 3.
Support of @generated will be made in a separate PR

@Tenischev Tenischev marked this pull request as ready for review September 1, 2023 21:35
@derberg
Copy link
Member

derberg commented Sep 4, 2023

shouldn't this be feat! to release 1.0? you have a fallback flag, yes, but still it must be explicitly set

@Tenischev Tenischev changed the title feat: update template for spring boot 3 feat!: update template for spring boot 3 Sep 4, 2023
@Tenischev
Copy link
Member Author

shouldn't this be feat! to release 1.0? you have a fallback flag, yes, but still it must be explicitly set

Yes, makes sense

@Tenischev Tenischev merged commit 20433cf into asyncapi:master Sep 4, 2023
19 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants