Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for channel parameters #352

Merged
merged 16 commits into from Dec 13, 2023

Conversation

Tenischev
Copy link
Member

@Tenischev Tenischev commented Nov 21, 2023

Description

details in #345

General support:

  • kafka
  • mqtt
  • amqp

Arbitrary methods:

  • kafka
  • mqtt
  • amqp

Related issue(s)
Resolves #345
Resolves #358

@Tenischev Tenischev marked this pull request as ready for review December 12, 2023 16:37
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shouldn't we have a proper mention in the readme?

@Tenischev
Copy link
Member Author

List of missing features are updated, also add attention bar about v3 support

@derberg derberg changed the title feat: add pattern support feat: add pattern support for channel parameters Dec 13, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derberg derberg changed the title feat: add pattern support for channel parameters feat: add support for channel parameters Dec 13, 2023
@Tenischev Tenischev merged commit b1e3eb2 into asyncapi:master Dec 13, 2023
14 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aeworxet
Copy link

@asyncapi/bounty_team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

AmqpConfig.java file has syntax errors Support parameter for channel
4 participants